-
-
Notifications
You must be signed in to change notification settings - Fork 263
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
0be986c
commit a7cb52f
Showing
3 changed files
with
14 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
{ | ||
"application/font-woff2": [ | ||
"woff2" | ||
], | ||
"text/jade": [ | ||
"jade" | ||
], | ||
|
a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougwilson why'd this land post-1.0.3?
a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm just reading on it's spec draft-ness a bit. i was going to 1.1.0 it
a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougwilson I'm confused why this is the only thing in the 1.1.0 bump lol.
a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
25a3d5c was supposed to be in 1.1.0 and not 1.0.3 but I f'd it up.
a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not view data updates as minor-bumpworthy haha
a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some discussion around this. If all data changes are patch, we'll soon be at 1.0.103. It was mostly that data alterations (like fixing a compressible or charset) would be patch and new types would be minor. Mainly because minors are "new features" and a new type is as close as this module gets to a new feature.
a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, I suppose.
a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modules that don't care about what particular types are within mime-db can simply depend on
mime-db@1
ormime-db@>= 1.0.2 < 2
or[email protected]
or some such. BTW I was going to ask if you wanted to updatecompressible
or should I?compressible
is a good candidate to not care about the specific version of1
to use.a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mime-db@^1
? ;) lolUh, does npm accept
1.x
? And I can, sure, or you can. Doesn't really matter to me.a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm accepts all those things. If only nodejs/node-v0.x-archive#7797 was accepted, there wouldn't be all this drama about using
^
in apackage.json
... :(a7cb52f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right that shit, forgot about that. fffff
kk I'ma go do 1.x