Skip to content

Commit

Permalink
add .woff2
Browse files Browse the repository at this point in the history
  • Loading branch information
alrra authored and dougwilson committed Sep 25, 2014
1 parent 0be986c commit a7cb52f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 0 deletions.
4 changes: 4 additions & 0 deletions db.json
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,10 @@
"compressible": false,
"extensions": ["woff"]
},
"application/font-woff2": {
"compressible": false,
"extensions": ["woff2"]
},
"application/framework-attributes+xml": {
"source": "iana"
},
Expand Down
7 changes: 7 additions & 0 deletions lib/compressible.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@
],
"notes": "File type is already compressed."
},
"application/font-woff2": {
"compressible": false,
"sources": [
"http://dev.w3.org/webfonts/WOFF2/spec/#IMT"
],
"notes": "File type is already compressed."
},
"application/gzip": {
"compressible": false
},
Expand Down
3 changes: 3 additions & 0 deletions lib/extensions.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"application/font-woff2": [
"woff2"
],
"text/jade": [
"jade"
],
Expand Down

11 comments on commit a7cb52f

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougwilson why'd this land post-1.0.3?

@dougwilson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm just reading on it's spec draft-ness a bit. i was going to 1.1.0 it

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougwilson I'm confused why this is the only thing in the 1.1.0 bump lol.

@dougwilson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25a3d5c was supposed to be in 1.1.0 and not 1.0.3 but I f'd it up.

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not view data updates as minor-bumpworthy haha

@dougwilson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some discussion around this. If all data changes are patch, we'll soon be at 1.0.103. It was mostly that data alterations (like fixing a compressible or charset) would be patch and new types would be minor. Mainly because minors are "new features" and a new type is as close as this module gets to a new feature.

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I suppose.

@dougwilson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules that don't care about what particular types are within mime-db can simply depend on mime-db@1 or mime-db@>= 1.0.2 < 2 or [email protected] or some such. BTW I was going to ask if you wanted to update compressible or should I? compressible is a good candidate to not care about the specific version of 1 to use.

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mime-db@^1? ;) lol

Uh, does npm accept 1.x? And I can, sure, or you can. Doesn't really matter to me.

@dougwilson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm accepts all those things. If only nodejs/node-v0.x-archive#7797 was accepted, there wouldn't be all this drama about using ^ in a package.json... :(

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right that shit, forgot about that. fffff

kk I'ma go do 1.x

Please sign in to comment.