Wrong scaling and position of previews in ranger (in both sway and hyprland)

[dev-forty-two]

I have a 2K screen and I am using a scaling factor of 1.35 with both sway and hyprland. This results in an issue similar to the one reported in #113. It does not happen with a scaling factor of 1.

Here is my log:

 _    _      _                                           
| |  | |    | |                                _     _   
| |  | | ___| |__   ___ _ __ _____   _  __ _ _| |_ _| |_ 
| |  | |/ _ \ '_ \ / _ \ '__|_  / | | |/ _` |_   _|_   _|
| |__| |  __/ |_) |  __/ |   / /| |_| | (_| | |_|   |_|  
 \____/ \___|_.__/ \___|_|  /___|\__,_|\__, |            
                                        __/ |            
                                       |___/     v2.9.1
[2023-08-27 03:00:17.661] [terminal] [info] TERM="foot", TERM_PROGRAM=""
[2023-08-27 03:00:17.662] [terminal] [info] PTY = /dev/pts/15
[2023-08-27 03:00:17.662] [wayland] [info] Using sway socket /run/user/1000/sway-ipc.1000.3151243.sock
[2023-08-27 03:00:17.666] [wayland] [info] Using sway socket /run/user/1000/sway-ipc.1000.3151243.sock
[2023-08-27 03:00:17.667] [wayland] [info] Canvas created
[2023-08-27 03:00:17.667] [main] [info] Listening for commands on socket /tmp/ueberzugpp-3244564.socket
[2023-08-27 03:00:17.709] [main] [info] Command received: {"action":"add","identifier":"preview","max_height":39,"max_width":82,"path":"/home/<username>/.cache/ranger/8a2b1a35dfe8d2460d043cbaa8ed62d8f350b04accc54827301ad5b17facdad2cce3532cbe757f5409b1faa1fdc8d571593be1782ad2b2939b8cff1b80bc4798.jpg","x":81,"y":1}
[2023-08-27 03:00:17.746] [opencv] [info] Loading image /home/<username>/.cache/ranger/8a2b1a35dfe8d2460d043cbaa8ed62d8f350b04accc54827301ad5b17facdad2cce3532cbe757f5409b1faa1fdc8d571593be1782ad2b2939b8cff1b80bc4798.jpg
[2023-08-27 03:00:27.075] [main] [error] SIGTERM received, exiting.
[2023-08-27 03:00:27.098] [main] [info] Exiting ueberzugpp

[Manix80]

same problem here with ncspot and ranger (hyprland)

also with a 4k scale screen in 1.5

[jstkdng]

hey, sorry for the delay. I gave it a go recently but can't find the culprit. I'd suggest using sixel or kitty as those seem to work fine.

[Kabouik]

I got the same issue on my phone running Droidian (Wayland, Phosh) and Foot terminal, with ytfzf as well as lobster (and likely nnn but I didn't configure it to use ueberzugpp yet):

Will try on Sway on my computer when I get some time to build ueberzugpp for it.

[jstkdng]

hey, I think that's an issue with ytfzf and your fzf setup. Since gnome wayland isn't supported it must be using sixel and that works fine

[nicobuzeta]

Same problem with alacritty, sway, and 4k at 1.5 scale

[15cm]

Same issue on Alacritty, Hyprland, Nvidia, with a 4k monitor under a 2 scale factor and a 2k Monitor under a 1.25 scale factor.

I managed to work around it by hard-coding a scale down on the coordinate and size in Ranger's image display code. See overlays/default.nix in the commit.

I verified it works in all trivial cases. Although in some corner cases, the rendered image location/depth could be incorrect, such as when you create a new other window the changes the terminal size or switch focus from the terminal to other windows whose Z axis is on top the terminal.

Verified cases:

• Full screen in a full size tmux pane:
• Split screen in a full size tmux pane:
• Split screen in a 1/4 size tmux pane:

BTW I originally found this issue from the issues in yazi. I tried a similar hard coded scale down in their code. It turned out to only fix the case of "Full screen in a full size tmux pane". As long as the terminal window or tmux pane doesn't occupy the full screen, the image position is still incorrect. I guess the calculation doesn't mange those complicated cases well.

[15cm]

Update: I manged to work around it in Yazi as well sxyazi/yazi#207 (comment). The patch I had applied to Yazi was different to Ranger, where I didn't downscale the size for the former.

[jstkdng]

Ignore my previous comment.

A proper fix is in master, only working in sway for now, please do test.

Edit: only working with opencv due to a libvips bug.

[jstkdng]

scaling is fixed for libvips too now on master, closing