Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate user and server errors in http handlers #2390

Closed
kradalby opened this issue Jan 29, 2025 · 0 comments · Fixed by #2398
Closed

Separate user and server errors in http handlers #2390

kradalby opened this issue Jan 29, 2025 · 0 comments · Fixed by #2398
Labels
enhancement New feature or request
Milestone

Comments

@kradalby
Copy link
Collaborator

At the moment, all errors that occur in http handlers, particularly the registration handlers, will end up as a "internal server error" or "bad request" giving the user very little information about what went wrong.

Some times this is correct when there was some unactionable server side issue, but some times it is within the users power to do something and they should get an error, for example if a token or registration key has expired.

We should make a separate Go error type for user web errors that we can check at the end of all paths to surface to users.

@kradalby kradalby added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 29, 2025
@kradalby kradalby added this to the v0.25.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant