Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip whitespace from private.key before parsing #287

Closed
kradalby opened this issue Jan 28, 2022 · 0 comments · Fixed by #289
Closed

Strip whitespace from private.key before parsing #287

kradalby opened this issue Jan 28, 2022 · 0 comments · Fixed by #289
Labels
bug Something isn't working

Comments

@kradalby
Copy link
Collaborator

There is some weird cases were it fails to parse the private key if it has a \n or other newline whitespace characters.

We should trim and strip privateKey before it is unmarshalled here:

headscale/app.go

Line 727 in 4d60aea

privateKeyEnsurePrefix := PrivateKeyEnsurePrefix(string(privateKey))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trim whitespace from privateKey before parsing juanfont/headscale
1 participant
@kradalby