Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make model blocks compatible with any frame-wise or chunk-wise model #43

Closed
juanmc2005 opened this issue May 4, 2022 · 1 comment
Closed
Labels
feature New feature or request
Milestone

Comments

@juanmc2005
Copy link
Owner

Problem

The current implementation of FrameWiseModel and ChunkWiseModel is highly dependent on pyannote.audio internals and published models. Any model accepted by the pipeline must be loaded with pyannote.audio. This is a problem because users may want to plug in custom models that don't share the same structure as models trained with or published by pyannote.

Idea

Make FrameWiseModel and ChunkWiseModel accept a broad definition of a model, e.g. a Callable[[torch.Tensor], torch.Tensor] or something similar. This way, any model that can ingest a tensor (in a certain format) and return another tensor (also in a certain format) could be plugged in.

@juanmc2005
Copy link
Owner Author

Implemented in #61

This was referenced Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant