Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Do not cache node outputs when node has zero or one outgoing connections #42

Open
juh9870 opened this issue Feb 2, 2025 · 0 comments
Open

[Performance] Do not cache node outputs when node has zero or one outgoing connections #42

juh9870 opened this issue Feb 2, 2025 · 0 comments
Labels
enhancement New feature or request P3 Third priority. Doesn't block a milestone, but still takes priority over other issues.
Milestone
v1.0.0 Beta

Comments

@juh9870
Copy link
Owner

juh9870 commented Feb 2, 2025

There is no need to cache node outputs values if the node only has zero or one outputs, saving on unnecessary cloning on each node's boundary.

Would also need to adjust ValueAdapter trait to operate on owned EValue instances
@juh9870 juh9870 added enhancement New feature or request P3 Third priority. Doesn't block a milestone, but still takes priority over other issues. labels Feb 2, 2025
@juh9870 juh9870 changed the title Do not cache node outputs when node has zero or one outgoing connections [Performance] Do not cache node outputs when node has zero or one outgoing connections Feb 2, 2025
@juh9870 juh9870 added this to the v1.0.0 Beta milestone Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P3 Third priority. Doesn't block a milestone, but still takes priority over other issues.
Projects
None yet
Milestone
v1.0.0 Beta
Development

No branches or pull requests
1 participant
@juh9870