Skip to content
This repository has been archived by the owner. It is now read-only.

Prepublish is being deprecated in npm5 #9

Open
mattdufeu opened this issue May 5, 2017 · 3 comments
Open

Prepublish is being deprecated in npm5 #9

mattdufeu opened this issue May 5, 2017 · 3 comments

Comments

@mattdufeu
Copy link

mattdufeu commented May 5, 2017

Apparently "prepublish" is changing in npm5 to only run on publish - http://blog.lholmquist.org/npm-prepublish-changes/.

To keep this boilerplate working in npm5, it appears to be as simple as change "prepublish" in package.json to "prepare".

I can raise a PR if you like?

@juliancwirko
Copy link
Owner

Hmm, so is it possible to leave both for now? Or is it backwards compatible somehow?

@mattdufeu
Copy link
Author

Prepare seems to work fine in npm4, not sure about 3.

@juliancwirko
Copy link
Owner

I think the deprecation is only about changing the logic of prepublish script and not removing it completly. And this is good because we need it only when publishing the lib. But of course I need to test it when rebuilding the boilerplate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants