Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extra space after emoji optional #29

Open
jacobstanley opened this issue Feb 16, 2017 · 0 comments
Open

Make extra space after emoji optional #29

jacobstanley opened this issue Feb 16, 2017 · 0 comments

Comments

@jacobstanley
Copy link

I am running the latest HEAD for NeoVim + the latest nightly of iTerm2, both of these things together allow for correct rendering of emoji with no character width problems or background color issues.

This means that the extra space which this plugin inserts after emoji is no longer required for my setup:

  function! s:emoji(name, ...)
    if b:github_emoji && has_key(s:emoji_code, tolower(a:name))
      let e = s:emoji_code[tolower(a:name)]
-     return join(map(copy(e), 'nr2char(v:val)'), '') . repeat(' ', 1 + (a:0 > 0 ? a:1 : 0))
+     return join(map(copy(e), 'nr2char(v:val)'), '') . repeat(' ', (a:0 > 0 ? a:1 : 0))
    else
      return ''
    endif
  endfunction

Would it be possible to make this an option that can be set via g:github_dashboard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant