You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
It's been a moment since this plugin was last maintained and quite a lot has changed so wanted to collect some thoughts on potential future improvements.
New build system (perhaps Vite) to produce an ES module and externalizing three.js
Typescript
Build plugin in Github action on commit to avoid having to checkin built plugin file (i.e ./build/depthkit.js)
I can migrate the code to es6 / esm (A build system won't be needed in that case). However I can also add a webpack build system to create an UMD build (w/o THREE) for thoses who don't want to use esm from browser (the only usage I see is, when using aframe lib direcly without aframe-dephkit component ; note that es6 as es-module-shims make esm available ~everywhere)
@ROBYER1 Why do you need depthkit to use typescript and vite? Your project should not be dependent on the build system of the library it uses. For example you are using THREE which is built with esm and rollup
@ROBYER1 Why do you need depthkit to use typescript and vite? Your project should not be dependent on the build system of the library it uses. For example you are using THREE which is built with esm and rollup
Makes sense to me, I'm still figuring out a lot of Vite but thanks for the explanation!
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It's been a moment since this plugin was last maintained and quite a lot has changed so wanted to collect some thoughts on potential future improvements.
./build/depthkit.js
)The text was updated successfully, but these errors were encountered: