Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask build tools and IDEs to upgrade to junit-platform-launcher 1.6.x #2028

Closed
8 tasks done
marcphilipp opened this issue Sep 25, 2019 · 16 comments
Closed
8 tasks done

Comments

@marcphilipp
Copy link
Member

marcphilipp commented Sep 25, 2019

Overview

In #1909 we've improved error reporting for engine discovery/execution failures. The relevant changes are in DefaultLauncher which is contained in the junit-platform-launcher artifact. Since most build tools and IDEs bundle that artifact we need to reach out to them and ask them to update to Jupiter/Vintage 5.6 (Platform 1.6).

Projects

List of projects and contacts to ping.

Deliverables

  • All of the above build tools and IDEs have been upgraded
@marcphilipp marcphilipp added this to the 5.7 M1 milestone Sep 25, 2019
@marcphilipp marcphilipp changed the title Ask build tools and IDEs to upgrade to junit-platform-launcher 5.6.0 Ask build tools and IDEs to upgrade to junit-platform-launcher 1.6.0 Sep 25, 2019
@akozlova
Copy link

IntelliJ doesn't bundle junit-platform-launcher anymore (about a year or even more), it downloads the launcher on tests start according to the version of the api used in the user's project.

@marcphilipp
Copy link
Member Author

@akozlova Thanks for the info! In that case, we're fine where IDEA is concerned.

@noopur2507
Copy link

Eclipse bug report to move to JUnit 5.6: bug 558873.

@sormuras
Copy link
Member

@bmuskalla
Copy link

Gradle has been upgraded to the 1.6.0 launcher which will be released as part of Gradle 6.4

@marcphilipp
Copy link
Member Author

@bmuskalla Thanks for letting us know! 👍

@sormuras sormuras changed the title Ask build tools and IDEs to upgrade to junit-platform-launcher 1.6.0 Ask build tools and IDEs to upgrade to junit-platform-launcher 1.6.x Mar 25, 2020
@sormuras
Copy link
Member

Created https://issues.apache.org/jira/browse/SUREFIRE-1764 to update Surefire's dependency.

@Tibor17
Copy link

Tibor17 commented Mar 25, 2020

In Surefire we are resolving the version of junit-platform-launcher in runtime. So we only need to fix it and not to upgrade it. Upgrading it would mean either breaking the users or forcing them to upgrade their POMs as well. Pls discuss it.

@sormuras
Copy link
Member

In Surefire [...] Pls discuss it.

Let's move the Surefire-related discussion to https://issues.apache.org/jira/browse/SUREFIRE-1764 -- this issue collecting the state of "all" build tools and IDEs.

@marcphilipp
Copy link
Member Author

@sormuras will create tickets for the remaining projects from the issue description.

@sormuras
Copy link
Member

sormuras commented Jun 4, 2020

Ant is "always up-to-date" as it doesn't bundle any artifact from JUnit 5 -- users are in charge to update their dependencies.

@sormuras
Copy link
Member

sormuras commented Jun 4, 2020

Netbeans includes JUnit 5.6 since Feb/Mar 2020, i.e. Netbeans 12: apache/netbeans#1977

@sormuras
Copy link
Member

sormuras commented Jun 4, 2020

Seems like @jlink is working on VS Code lately -- is VS Code already on Platform 1.6 or higher, Johannes?

Related issue: microsoft/vscode-java-test#975 "Support other JUnit 5 test engines / support JUnit 5 platform"

@sormuras sormuras modified the milestones: 5.7 M2, 5.7 Backlog Jun 4, 2020
@sormuras
Copy link
Member

sormuras commented Jun 4, 2020

Moved to 5.7 Backlog as not all IDEs/build tools are on JUnit Platform 1.6, resp. Jupiter 5.6.

@jlink
Copy link
Contributor

jlink commented Jun 4, 2020

@sormuras All I did is to enable VS Code to run other engine tests from an editor.

Under the hood VS Code is using some Eclipse-related library to start JUnit 5 tests in a very hacky way (i.e. through a faulty command line). It basically works with no engine correctly, with Jupiter it does the simple things right.

I offered to support them when migrating to use junit-platform-launcher. As of today they have not taken me up on my offer.

@sormuras sormuras removed their assignment Jun 4, 2020
@marcphilipp marcphilipp modified the milestones: 5.7 Backlog, 5.7 M2 Jun 5, 2020
@marcphilipp
Copy link
Member Author

Closing since all build tools and IDEs on the list have been contacted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants