Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect relative paths in include-ed content #1089

Open
fwkoch opened this issue Apr 11, 2024 · 1 comment
Open

Respect relative paths in include-ed content #1089

fwkoch opened this issue Apr 11, 2024 · 1 comment

Comments

@fwkoch
Copy link
Collaborator

fwkoch commented Apr 11, 2024

When you use the include directive to pull in contents from another file, content is processed relative to the base file (with the include directive). In the PR that added support for recursive includes #1082, we made sure recursive includes relative paths to be relative to the base file. However, it did not address image/embed/etc nodes in the included content which may also have relative paths.

We need to ensure any node type with a relative local path is updated to be relative to the base file when pulled in using an include directive.

@thesamovar
Copy link

+1 for this, I ran into this almost immediately when using the include directive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants