From de1730d55d2ed1bc501599df497878407fa8fa4a Mon Sep 17 00:00:00 2001 From: krassowski <5832902+krassowski@users.noreply.github.com> Date: Wed, 10 Jul 2024 09:23:48 +0100 Subject: [PATCH] Due to bad typing of `kwargs` it things that env is a str but in fact it in general should be a dict --- jupyter_server/services/kernels/kernelmanager.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jupyter_server/services/kernels/kernelmanager.py b/jupyter_server/services/kernels/kernelmanager.py index efeebf3c61..cc6ec8edc6 100644 --- a/jupyter_server/services/kernels/kernelmanager.py +++ b/jupyter_server/services/kernels/kernelmanager.py @@ -247,8 +247,8 @@ async def _async_start_kernel( # type:ignore[override] "Kernel args (excluding env): %r", {k: v for k, v in kwargs.items() if k != "env"} ) env = kwargs.get("env", None) - if env and isinstance(env, dict): - self.log.debug("Kernel argument 'env' passed with: %r", list(env.keys())) + if env and isinstance(env, dict): # type:ignore[unreachable] + self.log.debug("Kernel argument 'env' passed with: %r", list(env.keys())) # type:ignore[unreachable] # Increase the metric of number of kernels running # for the relevant kernel type by 1