Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycrdt throws PanicException in some cases which is unhandled #117

Closed
acnebs opened this issue May 30, 2024 · 3 comments · Fixed by #118
Closed

pycrdt throws PanicException in some cases which is unhandled #117

acnebs opened this issue May 30, 2024 · 3 comments · Fixed by #118
Labels
bug Something isn't working

Comments

@acnebs
Copy link

acnebs commented May 30, 2024

Description

Sometimes when calling ydoc.get_update(encoded_update) from pycrdt, a PanicException is thrown which I try to handle from userland but somehow seems to escape my try...except block.

You can read more about this exception from pyo3 in this GH issue: PyO3/pyo3#3519

Specifically, the PanicException that is thrown for me when calling ydoc.get_update(encoded_update) has this exception message:

called Result::unwrap() on an Err value: VarIntSizeExceeded(70)

Reproduce

Struggling to consistently reproduce, am unsure what exact binary payloads are causing the panic.

Expected behavior

No panics, or at least PanicExceptions I can catch.

@acnebs acnebs added the bug Something isn't working label May 30, 2024
Copy link

welcome bot commented May 30, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@davidbrochart
Copy link
Collaborator

Thanks, I opened #118.

@acnebs
Copy link
Author

acnebs commented May 31, 2024

Thanks, that's perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants