Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for embedding causes blue links on readthedocs #1673

Closed
maartenbreddels opened this issue Aug 25, 2017 · 6 comments
Closed

CSS for embedding causes blue links on readthedocs #1673

maartenbreddels opened this issue Aug 25, 2017 · 6 comments
Labels
docs good first issue resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@maartenbreddels
Copy link
Member

See http://ipyvolume.readthedocs.io/en/latest/index.html for an example, the links in the menu on the left are blue (it actually stars grey, but jumps to blue when the css is injected).

@jasongrout jasongrout modified the milestone: Future Aug 28, 2017
@pbugnion
Copy link
Member

Is this why all the links are blue on ipywidgets readthedocs?

@maartenbreddels
Copy link
Member Author

I don't think so, since on ipyvolume it starts grey, for ipywidgets it stars blue directly.

@jasongrout
Copy link
Member

I think this underlying issue causes the problem: jupyterlab/jupyterlab#3257

@jasongrout
Copy link
Member

I'll leave this open so that once the underlying jupyterlab issue is solved, we can be reminded to update our dependency to pull in the fix.

@jasongrout
Copy link
Member

FYI, I think JupyterLab just had a release with this fix, so we can go ahead and update to pull it in here.

@jasongrout jasongrout modified the milestones: Future, 7.0.x Dec 4, 2017
@jasongrout
Copy link
Member

We've now updated our dependency.

@jasongrout jasongrout modified the milestones: 7.1.x, 7.1 Dec 27, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs good first issue resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

4 participants