Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button font color different in classic notebook and jupyterlab #2062

Closed
oscar6echo opened this issue Apr 29, 2018 · 1 comment · Fixed by #2801
Closed

button font color different in classic notebook and jupyterlab #2062

oscar6echo opened this issue Apr 29, 2018 · 1 comment · Fixed by #2801
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@oscar6echo
Copy link
Contributor

For button with styles primay, success, info, warning, danger, the text appears black in jupyterlab and white in the classic notebook, as in the doc so presumably the intended color, and clearly the best option if you ask me.

Unfortunately the color attribute is not accessible, only the 'button_color' (background-color) says the doc. So it would be good to add color to the button style keys.

That would more than solve the slight inconsistency between JupyterLab and the classic notebook.
What do you think ?

@jeffyjefflabs
Copy link
Contributor

I noticed this too and found this issue. There's a mismatch in CSS variable names between ipywidgets and Jupyter Lab. I put in a ticket on the Lab side (jupyterlab/jupyterlab#7861) but I'm not sure where it should be fixed.

@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants