Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button icons offline #2997

Open
jifcon opened this issue Oct 16, 2020 · 2 comments
Open

Button icons offline #2997

jifcon opened this issue Oct 16, 2020 · 2 comments

Comments

@jifcon
Copy link

jifcon commented Oct 16, 2020

Hello!

I'm trying to develop an app (voila) that has some buttons and I included icons from FontAwesome. My question: Is it possible to include these icons if the application is going to be offline? I tried and when is offline, it shows squares instead of icons.

Thanks++!

@martinRenou
Copy link
Member

martinRenou commented Oct 28, 2020

There is this very similar issue on Thebe, where icons are missing because Thebe simply does not include Font-awesome: jupyter-book/thebe#185

I wonder if the best approach should not be to have ipywidgets ship font-awesome instead of assuming the Jupyter client provides it?

@BrenBarn
Copy link

BrenBarn commented May 8, 2021

I believe the best approach is to not use icon fonts at all. Instead use SVGs. This is what Jupyterlab decided to do years ago: jupyterlab/jupyterlab#30

Icon fonts are a bad idea. They interfere with user preferences about what fonts they want to see things in. Fonts are for text; UI icons are not text and should not use fonts; they are images and should use images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants