Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check public path for AMD modules #3474

Closed
jasongrout opened this issue Jun 2, 2022 · 1 comment
Closed

Check public path for AMD modules #3474

jasongrout opened this issue Jun 2, 2022 · 1 comment
Milestone

Comments

@jasongrout
Copy link
Member

jasongrout commented Jun 2, 2022

#3464 may need some more work. It seems that the webpack auto public path does not work inside of AMD modules, since by the time the AMD callback is called the currentScript is null. This would affect the various amd modules generated by the html manager. This is hinted at in #2191 (comment). See also #1652, #1650.

A workaround for automatically figuring out the public path in an AMD module using the require 'module' magic dependency is at jupyter-widgets/widget-cookiecutter#103

@jasongrout jasongrout added this to the 8.0 milestone Jun 2, 2022
@jasongrout
Copy link
Member Author

@xiaochen-db and I confirmed that using the html manager libembed-amd.js file from requirejs is currently broken on master. We do indeed need the fix from jupyter-widgets/widget-cookiecutter#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant