Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the embedder url configurable #4

Closed
SylvainCorlay opened this issue Dec 15, 2016 · 5 comments
Closed

Make the embedder url configurable #4

SylvainCorlay opened this issue Dec 15, 2016 · 5 comments

Comments

@SylvainCorlay
Copy link
Member

This would be useful to have a local use of the extension that use another URL for the javascript.

As per conversation in #3 .
@mpacer
Copy link
Member

mpacer commented Dec 15, 2016

If this is going to be configurable here, we probably should also make it configurable in nbconvert, yes?

@SylvainCorlay
Copy link
Member Author

Sorry I did not respond to this. +1 on making it configurable globally.

@infinity0
Copy link

Could we please think about this sort of thing (being able to use local copies rather than downloading everything) before release? For jupyter in general I mean, not just this project. Otherwise it makes packaging this for Debian more painful. And it is already incredibly painful due to all this NPM crap.

@maartenbreddels
Copy link
Contributor

#16 makes this configurable actually, so merging that could close this issue.

@jasongrout
Copy link
Member

Closed by #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@infinity0 @jasongrout @maartenbreddels @SylvainCorlay @mpacer