Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The top buttons of feedback are not stable #1830

Open
brichet opened this issue Sep 12, 2023 · 2 comments
Open

The top buttons of feedback are not stable #1830

brichet opened this issue Sep 12, 2023 · 2 comments
Labels
bug

Comments

@brichet
Copy link
Contributor

brichet commented Sep 12, 2023

When navigating into a feedback document, there is a Top button on each cell, to go to the top of the document.

The HTML needs to be trusted to display Mathjax correctly (up-left button of the document).
When the HTML is trusted, it seems the Top buttons do not work anymore, and require a token to carry on.

Peek 2023-09-12 17-12

Clicking again on the trust button fix it.

Operating system

Ubuntu 22.04

nbgrader --version

0.9.1

jupyter --version

jupyterlab 4.0.5
notebook 7.0.3

Expected behavior

Navigate to the top of the document when clicking on top button.
@brichet brichet added the bug label Mar 21, 2024
@jeflem
Copy link
Contributor

jeflem commented Oct 18, 2024

TOC links (that is, 'down') also do not work. Immediately after opening the HTML file browser console shows

Blocked script execution in 'blob:https://my-domain.com/4ecdde7e-8a8a-4017-8830-4349fa87e291' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.

After clicking a TOC link or 'top' the console shows

Refused to frame 'https://my-domain.com/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'none'".

This might be related to #1870 or at least a similar solution could work. Haven't tried yet.

@jeflem
Copy link
Contributor

jeflem commented Oct 19, 2024

Turns out that my link problem in feedback files is a more general problem with links in HTML files if JupyterLab is running on a JupyterHub. Even simple HTML files fail:

<html>
    <head>
        <title>Test</title>
    </head>
    <body>
        <a href="#test">Test</a>
        <h1 id="test">Test</h1>
    </body>
</html>

Clicking the link yields console messages described in my previous post (with and without trusting HTML).

@jeflem jeflem mentioned this issue Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brichet @jeflem