Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.2.1 #2982

Closed
9 tasks done
gnestor opened this issue Oct 26, 2017 · 8 comments
Closed
9 tasks done

Release 5.2.1 #2982

gnestor opened this issue Oct 26, 2017 · 8 comments

Comments

@gnestor
Copy link
Contributor

gnestor commented Oct 26, 2017

We should do a patch release primarily for #2981. Here are the other PRs we plan to include: https://github.com/jupyter/notebook/pulls?q=is%3Apr+is%3Aclosed+milestone%3A5.2.1

@gnestor gnestor added this to the 5.2.1 milestone Oct 26, 2017
@gnestor
Copy link
Contributor Author

gnestor commented Oct 26, 2017

@Carreau What would be the best approach for including only specific PRs merged to master since the "release 5.2.0" commit? Create a new branch and chery-pick individual commits? Checkout the "release 5.2.0" commit and then manually merge in individual branches?

@Carreau
Copy link
Member

Carreau commented Oct 26, 2017

@Carreau What would be the best approach for including only specific PRs merged to master since the "release 5.2.0" commit? Create a new branch and chery-pick individual commits? Checkout the "release 5.2.0" commit and then manually merge in individual branches?

A branch that diverge at 5.2.0 and cherry-picking up PRs, should be doable

Once the branch is created you might be able to just mention MeeseeksDev in relevant PRs and ask it to backport to <branchname>. It will open PRs though, but it might be easier than backporting by hand.

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 26, 2017

Oweee, Happy to help

@gnestor
Copy link
Contributor Author

gnestor commented Oct 26, 2017

It worked! Thanks MeeseeksDev!! 👍👍

@gnestor
Copy link
Contributor Author

gnestor commented Oct 30, 2017

OK, I have backported all of the PRs marked with 5.2.1 milestone 👍

@gnestor
Copy link
Contributor Author

gnestor commented Oct 30, 2017

notebook 5.2.1rc1 is available on PyPI. Give it a try: https://pypi.org/project/notebook/#history

@gnestor
Copy link
Contributor Author

gnestor commented Nov 2, 2017

I'm considering releasing 5.2.1 tomorrow (Thursday). Any objections?

@gnestor
Copy link
Contributor Author

gnestor commented Nov 3, 2017

@gnestor gnestor closed this as completed Nov 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants