Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize os operations in conftest.py #6622

Closed
jtpio opened this issue Nov 16, 2022 · 0 comments · Fixed by #6624
Closed

Modernize os operations in conftest.py #6622

jtpio opened this issue Nov 16, 2022 · 0 comments · Fixed by #6624
Labels
good first issue
Milestone
7.0

Comments

@jtpio
Copy link
Member

jtpio commented Nov 16, 2022

Currently in conftest.py there are multiple uses of os.path.join: https://github.com/jupyter/notebook/blob/main/tests/conftest.py

Ideally it would be great to do a pass on that file to use pathlib: https://docs.python.org/3/library/pathlib.html
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Nov 16, 2022
@jtpio jtpio added good first issue and removed status:Needs Triage Applied to issues that need triage labels Nov 16, 2022
@jtpio jtpio added this to the 7.0 milestone Nov 16, 2022
@jtpio jtpio mentioned this issue Nov 16, 2022
Merged
@kianelbo kianelbo mentioned this issue Nov 16, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Use pathlib instead of os.path.join in tests/conftest.py
1 participant
@jtpio