Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation email still sent for allow-listed users #193

Closed
lambdaTotoro opened this issue Nov 9, 2021 · 0 comments · Fixed by #195
Closed

Confirmation email still sent for allow-listed users #193

lambdaTotoro opened this issue Nov 9, 2021 · 0 comments · Fixed by #195
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lambdaTotoro
Copy link
Collaborator

I just did a test for an unrelated feature locally and found out that currently, if self-serve authorization is enabled, the email is always sent out, even if the user that's signing up is already listed as an admin.

There's no big harm done, because the only thing that could happen is that anyone clicks on the link to find an 'already authorized' message, but that really shouldn't be the case. I wonder if we could have a direct 'thanks for signing up, you were pre-approved, you can now log in'-type message instead.

@lambdaTotoro lambdaTotoro added the bug Something isn't working label Nov 9, 2021
@lambdaTotoro lambdaTotoro added this to the Version 1.1 milestone Nov 9, 2021
@lambdaTotoro lambdaTotoro self-assigned this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant