user-scheduler: update to use kube-scheduler 1.28, from 1.26 - require k8s 1.24+ #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/test-upgrade-kube-scheduler
branch
7 times, most recently
from
b00fd64 to
be5c80d
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/test-upgrade-kube-scheduler
branch
from
be5c80d to
f84f085
Compare
consideRatio
changed the title
manics
reviewed
Jan 12, 2024
consideRatio
force-pushed
the
pr/test-upgrade-kube-scheduler
branch
from
0667786 to
ec8e3e8
Compare
|
It appears that CircleCI behaves differently from GitHub actions. CircleCI seem to test the state of the branch, while GitHub tests the state of the PR if merged - so when we close/re-opened github actions started testing with #3313 that had been merged into main since this branch was created, while CircleCI didn't. The feature to merge first and test later is requested in https://ideas.circleci.com/cloud-feature-requests/p/show-test-results-for-prospective-merge-of-a-github-pr, where the resolution was to use a orb that now seems archived and possibly deprecated - see https://circleci.com/developer/orbs/orb/circleci/build-tools#commands-merge-with-parent. Anyhow, tests are now passing after a rebase. |
manics
approved these changes
Jan 14, 2024
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jan 14, 2024
jupyterhub/zero-to-jupyterhub-k8s#3312 Merge pull request #3312 from consideRatio/pr/test-upgrade-kube-scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking because we introduce an assumption of k8s 1.24+.