Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 3.3.8 #3473

Merged

Conversation

consideRatio
Copy link
Member

No description provided.

@manics
Copy link
Member

manics commented Jul 31, 2024

Shouldn't this be against the 3.x branch? Then we can drop the unreleased changes section.

@consideRatio consideRatio force-pushed the pr/add-changelog-for-3.3.8 branch 2 times, most recently from fd87d3e to 202e8cd Compare July 31, 2024 10:11
@consideRatio
Copy link
Member Author

consideRatio commented Jul 31, 2024

We should update the changelog in main and for 3.x, and I mean to cherry-pick this commit into 3.x after merging to mimic what was done for other patch releases. It could be done the other way around as well though.

The unreleased section changes was unrelated to the PR, and I could extract them but I figured was OK to bundle in this.

@manics do you think its ok to proceed like this?

@consideRatio
Copy link
Member Author

@manics thank you for the neat "summarize linkcheck issues" btw!!

image

@consideRatio
Copy link
Member Author

Preview:
image

@manics
Copy link
Member

manics commented Jul 31, 2024

Looks like we've got unreleased changes in the changelogs for other backported relaseses. Given we need to make this release quickly it's fine for now, but in future I think a changelog (which forms part of a tag) shouldn't containfuture changes.

@consideRatio consideRatio force-pushed the pr/add-changelog-for-3.3.8 branch from 202e8cd to 41c958f Compare July 31, 2024 10:26
@consideRatio consideRatio merged commit 6a084f9 into jupyterhub:main Jul 31, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants