Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab-system-monitor renders [horribly] when rendering in skideshow mode #4

Closed
perllaghu opened this issue Dec 21, 2022 · 4 comments · Fixed by #21
Closed

jupyterlab-system-monitor renders [horribly] when rendering in skideshow mode #4

perllaghu opened this issue Dec 21, 2022 · 4 comments · Fixed by #21
Labels
bug Something isn't working

Comments

@perllaghu
Copy link

When displaying a notebook in "Slideshow" mode, the extension jupyterlab-system-monitor is included... and takes up a large amount of the display:

See https://photos.app.goo.gl/iPpsJY5rzQEnuVpT8

Context

I'm running a jupyterlab docker image created thus:

FROM jupyter/minimal-notebook:2022-10-17

RUN pip install jupyterlab_rise  &&  mamba clean --all -f -y

RUN pip install jupyterlab-system-monitor  &&  mamba clean --all -f -y

WORKDIR $HOME
USER $NB_USER

The notebook is actually one I use to test rise in a service I run.... with more complex notebook images - so I realise the actual cells won't run :chuckle:

Expectation

I would not have expected the extension to be included in the slide-show rendering

@perllaghu perllaghu added the bug Something isn't working label Dec 21, 2022
@martinRenou
Copy link
Member

cc. @jtpio for awareness

@jtpio
Copy link
Member

jtpio commented Dec 21, 2022

Thanks for the ping.

Wondering if this happens with other extensions that put widgets in the top area.

Also I was hoping to move some of the functionalities of the system-monitor extension to the jupyter-resource-usage at some point to ease maintenance and consolidate the existing extension. Probably something to do after the JupyterLab 4 final release.

@perllaghu
Copy link
Author

Wondering if this happens with other extensions that put widgets in the top area.

Happy to try, if you can suggest one

@krassowski
Copy link
Contributor

krassowski commented Dec 21, 2022

I believe this is a bug in jupyterlab-rise that I highlighted in my review: damianavila/RISE#605 (review) and it also happens for jupyterlab-citation-manager (which takes even more space).

I dissected this in damianavila/RISE#605 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants