Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning when importing jupyter_server.transutils._ #47

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Fix deprecation warning when importing jupyter_server.transutils._ #47

merged 1 commit into from
Apr 8, 2021

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Apr 7, 2021 •
edited
Loading

I am seing this warning when starting JupyterLab since a couple of days:

lib/python3.9/site-packages/jupyter_server/transutils.py:13: FutureWarning: The alias `_()` will be deprecated. Use `_i18n()` instead.

I am not sure nbclassic is the culprit here, but I guess it's worth doing it anyway

@welcome
Copy link

welcome bot commented Apr 7, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@martinRenou martinRenou force-pushed the fix_jupyter_server_deprecation_warning branch from 4fe2305 to 967025f Compare April 7, 2021 13:14
@jtpio
Copy link
Member

jtpio commented Apr 7, 2021

Thanks!

Should the jupyter_server dependency also be bumped if this renaming was added to the 1.5.0 release?

https://github.com/jupyterlab/nbclassic/blob/0e30d80de5546b50c956ad33ec6e86b6cd554dba/setup.py#L58

@martinRenou martinRenou force-pushed the fix_jupyter_server_deprecation_warning branch from 967025f to 603865d Compare April 7, 2021 13:33
jtpio
jtpio approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit d527b3f into jupyter:master Apr 8, 2021
@welcome
Copy link

welcome bot commented Apr 8, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@blink1073
Copy link
Contributor

Thanks! I'll cut a release with this tomorrow.

@martinRenou martinRenou deleted the fix_jupyter_server_deprecation_warning branch April 8, 2021 07:13
@martinRenou
Copy link
Member Author

Thank you!

@blink1073
Copy link
Contributor

https://pypi.org/project/nbclassic/0.2.7/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @jtpio @blink1073