Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test Frontend #18

Closed
fcollonval opened this issue Mar 8, 2021 · 2 comments
Closed

Unit Test Frontend #18

fcollonval opened this issue Mar 8, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@fcollonval
Copy link
Member

My bad on this one - there is no front-end tests anymore

This should be corrected - especially the cells rechunk + chunk/comment matching need desperately tests.

@fcollonval fcollonval added the enhancement New feature or request label Mar 8, 2021
@bollwyvl bollwyvl changed the title Test front Unit Test Frontend Mar 12, 2021
@bollwyvl
Copy link
Contributor

Ha, in starting #30, I didn't realize that all of the tests were broken! I'll be just turning them off!

I think before we even do this, we should:

  • turn on as many compiler options as possible
    • strictNullCheck alone can save many headaches
  • increase the aggression of the linter
    • pulling more of the current baseline configuration from core is probably the quickest way

Once we do bring back pure jest unit tests (which invoke no browser), I propose we:

  • leverage our JSON Schema from Add OpenAPI description of the extension API #17
    • ideally with something like fast-check and json-schema-fast-check
    • this is massively useful at finding corner cases, as getting JSON validation into different parts of the app will cut down on ambiguous data
  • move as many operations against data as we can out of react components and their event handlers/didShouldCouldMaybeUnMounts (Move to VDomRendererModel #19) into discrete, testable functions of manager/model classes which don't require reasoning about the react lifecycle
  • get them under coverage, with a threshold, uploaded to codecov
  • only run them linux
    • since they only run in nodejs, we're testing... nodejs. no users will be running server-side node.
    • this can gate heavier browser-based tests

@fcollonval fcollonval self-assigned this Mar 13, 2021
@bollwyvl
Copy link
Contributor

bollwyvl commented Apr 8, 2021

Closed by #33

@bollwyvl bollwyvl closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants