-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide jupyterlite-sphinx[xeus]
and jupyterlite-sphinx[pyodide]
extras?
#243
Comments
That seem reasonable; if you believe it is also necessary on |
I think we will have to think about this a bit. In most cases, it shouldn't be a problem, but if someone needs a specific version of any of the kernels, the resolver may not be able to solve and proceed further. Unfortunately, there isn't a For example, with jupyterlite-sphinx/pyproject.toml Line 19 in eaaa12f
which means
which means that an unsuspecting user would face an error if they were to assume that the below requirement would work: jupyterlite-sphinx[pyodide]
jupyterlite-pyodide-kernel>=0.5.0 So, we can proceed with adding these extras only if we can keep up
I think this could work, as it would at least allow testing the installation in CI. Maybe you would have some thoughts about this, @jtpio? |
Problem
Users need to install both
jupyterlite-xeus
andjupyterlite-pyodide-kernel
separately withjupyterlite-sphinx
as a part of their docs requirements/lockfiles or with their[docs]
(or sometimes[doc]
) optional dependencies.Proposed solution
As mentioned in the issue title, we could provide the
jupyterlite-sphinx[xeus]
andjupyterlite-sphinx[pyodide]
extras, because usingjupyterlite-sphinx
(and in-turn, JupyterLite), probably doesn't make sense without at least one of them installed?Additional context
jupyterlite-core
side, butjupyterlite-sphinx
as a dependency is more user-facing in comparison.sphinx-gallery
, can provide their own extras using our extrasN.B. If someone would need a specific version of the
jupyterlite-pyodide-kernel
orjupyterlite-xeus
, they will need to list it as a separate requirement.The text was updated successfully, but these errors were encountered: