Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make hard-coded emscripten-abi optional or parametrizable #142

Open
DerThorsten opened this issue Jan 10, 2025 · 1 comment
Open

make hard-coded emscripten-abi optional or parametrizable #142

DerThorsten opened this issue Jan 10, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@DerThorsten
Copy link
Collaborator

Problem

Hardcoded emscripten-abi

xeus/jupyterlite_xeus/create_conda_env.py

Line 53 in 528fe3f

specs.append("emscripten-abi=3.1.45")

Proposed Solution

allow to disable this with an option / or provide api itself with an option

Additional context
@DerThorsten DerThorsten added the enhancement New feature or request label Jan 10, 2025
@martinRenou martinRenou added this to the 3.0.0 milestone Jan 10, 2025
@martinRenou
Copy link
Member

Let's make it a 3.1.0 feature

@martinRenou martinRenou removed this from the 3.0.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DerThorsten @martinRenou