Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override E elements #73

Closed
qcoumes opened this issue May 31, 2022 · 2 comments
Closed

Allow to override E elements #73

qcoumes opened this issue May 31, 2022 · 2 comments

Comments

@qcoumes
Copy link
Contributor

qcoumes commented May 31, 2022

I need to customize the behavior of some elements inside ElasticsearchQueryBuilder. Sadly it is not currently possible to just change these element without overriding every method to use my custom element.

Could you consider making these elements an attribute of the class so that we can override them more easily, i.e. something like :

class ElasticsearchQueryBuilder(LuceneTreeVisitorV2):
    
    E_MUST = EMust
    E_SHOULD = Eshould
    [...]

I can make a PR if you agree with the idea.

@alexgarel
Copy link
Member

Sounds good to me @qcoumes

@alexgarel
Copy link
Member

Resolved by @qcoumes PR #75 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants