Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: make require of puppeteer effectful #27

Open
mikesol opened this issue Mar 17, 2021 · 0 comments
Open

Proposal: make require of puppeteer effectful #27

mikesol opened this issue Mar 17, 2021 · 0 comments

Comments

@mikesol
Copy link

mikesol commented Mar 17, 2021

The require of puppeteer via var puppeteer = require("puppeteer"); crashes when the puppeteer library is not used (ie when using packages like chrome-aws-lambda). If the require of puppeteer is effectful and puppeteer is passed to launch, or alternatively if puppeteer is not exposed and is just required on the fly in launch, then that will prevent the crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant