Subtract "missing key" entries from total translated keys, so that percentage is more accurate

[svogt]

It would be good if we subtracted entries in "missing key" state from the total of translated keys. That way, the total count should better match what is actually translated and the overall percentage should be correct again.

[jutzig]

This is actually more tricky than one would think.
Reviews cannot be used for this, because they are computed asynchronously after a property file has been persisted.
The completion state however is computed directly as part of the serialization process and for performance reasons it simply compares the amount of serialized Key/Value pairs with the amount of keys in the template. The Template is not loaded or evaluated for this, the value comes directly from the Database.
Currently I only see two possibilites:

1. The Missing Key review actively modifies the completion state of resource
2. During serialization the template must be loaded as well and each translation key must be compared against the template. That comes with a performance penalty.

None of these sound like a perfect solution. Do you have an idea for an alterantive?

[svogt]

Not yet, though I would not object going for no. 1 first and maybe find a better solution later.