Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No descriptions for shortcut keys in telescope help menu #22

Open
phantomwhale opened this issue Apr 11, 2023 · 4 comments
Open

No descriptions for shortcut keys in telescope help menu #22

phantomwhale opened this issue Apr 11, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request will do Good suggestion, will implement it shortly

Comments

@phantomwhale
Copy link

Not sure how feasible this is (or if it's a bug with just my setup) but the default help menu (e.g. the menu invoked with <C-?> when inside the telescope modal) has the description anonymous for the 6 custom shortcut options in the zoxide picker. Screenshot shown below:

image

Is it possible to update the default zoxide picker configuration to provide values for this help menu? Not sure if Telescope allows this level of detail in the configuration, but in TJ I trust so hopefully it's possible.

@phantomwhale
Copy link
Author

At a casual eyeball, I'm guessing these values are just LUA table keys (e.g. within telescope default actions: https://github.com/nvim-telescope/telescope.nvim/blob/6258d50b09f9ae087317e392efe7c05a7323492d/lua/telescope/mappings.lua#L159)

Whereas this plugin uses inline "anonymous" tables, which telescope simply renders as anonymous (e.g. https://github.com/nvim-telescope/telescope.nvim/blob/6258d50b09f9ae087317e392efe7c05a7323492d/lua/telescope/mappings.lua#L159)

I might just have enough basic Lua in me to cobble together a PR, if that would help? Might be a while coming though, in all honesty! Otherwise hopefully that's enough of a steer (and hopefully a correct steer too, of course !!!!) to get someone started on the problem a little bit faster.

@jvgrootveld
Copy link
Owner

Ty for your suggestion! I was a little absent lately due to ... Life. I just want to let everyone know will check all Open issues and PR's shortly.

@jvgrootveld
Copy link
Owner

jvgrootveld commented Aug 8, 2024

@phantomwhale Interesting! I'm almost certain TJ did think about this. Thanks for investigating the issue further I will check this myself also and try to update this.

ETA: I try to reproduce this, but I'm not getting the same view as you. Could you give me an easy reproduction path?

@jvgrootveld jvgrootveld self-assigned this Aug 8, 2024
@jvgrootveld jvgrootveld added enhancement New feature or request will do Good suggestion, will implement it shortly labels Aug 8, 2024
@phantomwhale
Copy link
Author

I've had a play around, but can't seem to figure out what in my setup might be causing this.

The breadcrumbs I have to go off are:

(a) My Telescope configuration - https://github.com/phantomwhale/dotfiles/blob/master/neovim/.config/nvim/after/plugin/telescope.lua

(b) When I load up the Zoxide search (using <leader>sz keymap) I see the error message:

"No name available for anonymous functions."

This appears to come from https://github.com/nvim-telescope/telescope.nvim/blob/5972437de807c3bc101565175da66a1aa4f8707a/lua/telescope/actions/init.lua#L1332-L1336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request will do Good suggestion, will implement it shortly
Projects
None yet
Development

No branches or pull requests

2 participants