fix: remove unfinished mutations for consents and customer data and move logic to account store #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove logic to account store
fix: correct typo in class name
CarinaDraganJW
approved these changes
Mar 7, 2022
…wplayer/ott-web-app into dbudzinski/move-logic-to-store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The user / account components had a half-working query / mutation implementation for retrieving and updating customer and consent data. The mutations and queries worked to initially load data but did not properly update nor handle errors. Additionally, there was a confusing duplication of customer data between the queries and the Account store and there were spaghetti dependencies on account store and account service at different levels. To clean up and solve all of these issues, I moved the consent logic into the Account Store and removed all the mutation and query stuff.
Steps completed:
According to our definition of done, I have completed the following steps: