Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): fix error state for preview and demo modes #423

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

AntonLantukh
Copy link
Collaborator

Description

  • For the preview and demo state when settings are not defined - the empty screen is shown. Fixed it showing the error in the DemoConfigDialog.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Jan 9, 2024

Visit the preview URL for this PR (updated for commit faed228):

https://ottwebapp--pr423-fix-no-defined-confi-t6tqklfo.web.app

(expires Thu, 08 Feb 2024 14:20:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@AntonLantukh AntonLantukh self-assigned this Jan 9, 2024
@AntonLantukh AntonLantukh requested a review from dbudzins January 9, 2024 14:45
@AntonLantukh AntonLantukh marked this pull request as ready for review January 9, 2024 14:45
@AntonLantukh AntonLantukh merged commit ca9d905 into develop Jan 10, 2024
9 checks passed
@AntonLantukh AntonLantukh deleted the fix/no-defined-config-state branch January 10, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants