Fix / Loading skeletons #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(project): correct loading skeleton in shelf and card refactor(project): shelf title ternary readability refactor(project): revert loading state for scheduled start date
MelissaDTH
force-pushed
the
fix/home-skeleton
branch
from
a0fbe5d to
09f4680
Compare
AntonLantukh
approved these changes
May 6, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cardcomponent by usingisPlaceholderDatato determine if data is still loading. Previously, loading always returnedfalse, but it is needed to check for the presence of placeholder data to get the correct loading status.Example of the loading state
Steps completed:
According to our definition of done, I have completed the following steps: