Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong protocol and url path #588

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

darkoatanasovski
Copy link
Collaborator

@darkoatanasovski darkoatanasovski commented Jul 30, 2024

Description

This PR fixes a bug introduced by removing the InPlayer SDK. It should be deployed as a hotfix because the latest release is affected.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@darkoatanasovski darkoatanasovski requested review from AntonLantukh and removed request for AntonLantukh July 30, 2024 21:26
Copy link

Visit the preview URL for this PR (updated for commit 3037adc):

https://ottwebapp--pr588-fix-sims-domain-prot-rbwxuz1d.web.app

(expires Thu, 29 Aug 2024 21:27:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@darkoatanasovski darkoatanasovski merged commit de75eb7 into develop Jul 31, 2024
10 checks passed
@darkoatanasovski darkoatanasovski deleted the fix/sims-domain-protocol branch July 31, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants