Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): support media type for menu #610

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

CarinaDraganJW
Copy link
Contributor

Description

  • Support media type for menu items

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Sep 12, 2024

Visit the preview URL for this PR (updated for commit 5f55cb1):

https://ottwebapp--pr610-feature-owa-88-suppo-dwadpzku.web.app

(expires Thu, 17 Oct 2024 11:25:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@CarinaDraganJW CarinaDraganJW merged commit 80acd7f into develop Sep 19, 2024
10 checks passed
@CarinaDraganJW CarinaDraganJW deleted the feature/OWA-88.support-media-type-for-menu branch September 19, 2024 07:46
This was referenced Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants