Fix / card grid rendering previous items #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
AntonLantukh and
dbudzins
as code owners
|
Visit the preview URL for this PR (updated for commit 6feac0d): https://ottwebapp--pr613-fix-layout-grid-impr-9j1v1g03.web.app (expires Sat, 19 Oct 2024 11:12:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
royschut
reviewed
Sep 19, 2024
royschut
approved these changes
Sep 19, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When switching playlists pages or using the playlist filters in a wrapped shelf, the cards would render the previous item briefly. This creates some noise in the loading state as multiple page changes occur stacked.
This PR addresses that and also includes some performance improvements. The main cause of the old item being shown was the
keybeing set to the column index in the grid. Because this doesn't change when a new playlist is set as prop, the card doesn't re-render immediately and keeps the previous poster image.