-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat / screen animations #614
Conversation
Visit the preview URL for this PR (updated for commit 7d594e5): https://ottwebapp--pr614-feat-screen-animatio-708kr0dn.web.app (expires Sat, 19 Oct 2024 13:43:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
fcd1492
to
dcb5e12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Good choice to use <Fade>
for this purpose!
Somewhere in the future it would be nice to use the View Transition API to make a cool transition from a shelf to a video detail page. Only supported in modern browsers, though ;) This idea was on my idea proposal list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great subtle improvement.
I have a small doubt about the z-index
(+ the comments on #613)
dcb5e12
to
29855b9
Compare
I reverted the media screen fade when the mediaid changes because this causes the player to re-render when loading the next video. Although, this also happens when the media isn't cached, it's more noticeable now. I believe we can solve this when we move the player to a parent component. This also solves some Airplay issues that we're having. This is a big change, so not for now... |
Description
This PR makes the transitions to screens (home, playlist and media) more smooth by adding a fade transition.
To prevent layout jumps while navigating the app, I also set the body
overflow-y
toscroll
to make the viewport width stable.The shelf list on the homepage uses a staggered animation (each shelf fades in with a small delay).
Edit I noticed that the screen fade in animation didn't work every time. After some debugging, I found this is caused by a browser optimisation causing it to batch the paint. By manually triggering a reflow, the animation does work every time. There are alternatives like the Web Animation API, but this isn't supported on older devices (TV platforms).
screen-fade2.mov
Let me know what you think! 😄