Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityGroup incorrectly marked available if rules fail #120

Open
mdbooth opened this issue Dec 12, 2024 · 0 comments
Open

SecurityGroup incorrectly marked available if rules fail #120

mdbooth opened this issue Dec 12, 2024 · 0 comments
Milestone

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Dec 12, 2024

Security group creation and rule addition both happen in 'create', which only happens once, and sets security group ID even if the rules were not created. Therefore, if the security group is successfully created but the rules are not created, the next reconcile will set the security group id and incorrectly mark it available.

I think the simplest solution is to move rule creation in to a separate 'update' action.

@mdbooth mdbooth added this to the Release 1.1 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant