Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile refactoring #109

Closed
kuritka opened this issue Apr 30, 2020 · 2 comments · Fixed by #201
Closed

Makefile refactoring #109

kuritka opened this issue Apr 30, 2020 · 2 comments · Fixed by #201
Assignees
Milestone

Comments

@kuritka
Copy link
Collaborator

kuritka commented Apr 30, 2020

Makefile targets are dependent on full.sh and environment variables declared at the same file.

  • refactor Makefile to GNU call Functions to get rid of dependencies on full.sh.
  • refactor all places where full.sh is used (i.e. terratest build pipe)
@kuritka kuritka added the enhancement New feature or request label Apr 30, 2020
@ytsarev ytsarev added this to the 0.7 milestone May 16, 2020
@kuritka kuritka added refactoring and removed enhancement New feature or request labels Jun 1, 2020
@ytsarev ytsarev modified the milestones: 0.7, 0.8 Oct 26, 2020
@kuritka kuritka self-assigned this Nov 3, 2020
@kuritka
Copy link
Collaborator Author

kuritka commented Nov 5, 2020

Hi @ytsarev, if you have time, please look on the report below. If there is something which obviously shouldn't be in Makefile (obsolete, we don't use it,...), let me know.

  • bold - moved to new Makefile and accessible make <target>
  • crossed out - functionality is moved to new Makefile but not accessible via targets
  • normal text - ready to move to new makefile, I'm trying to keep it as much lightweight as possible

old

  • all
  • bundle
  • bundle-build
  • clean-test-apps
  • controller-gen
  • create-k8gb-ns
  • create-test-ns
  • debug-local
  • debug-test-etcd
  • demo-failover
  • demo-roundrobin
  • deploy
  • deploy-first-k8gb
  • deploy-full-local-setup
  • deploy-gslb-cr
  • deploy-gslb-operator
  • deploy-gslb-operator-14
  • deploy-local-cluster
  • deploy-local-ingress
  • deploy-second-k8gb
  • deploy-test-apps
  • deploy-two-local-clusters
  • destroy-full-local-setup
  • destroy-local-cluster
  • destroy-two-local-clusters
  • dns-smoke-test
  • dns-tools
  • docker-build
  • docker-push
  • docker-test-build-push
  • fmt
  • generate
  • infoblox-secret
  • init-failover
  • init-round-robin
  • install
  • kustomize
  • lint
  • manager
  • manifests
  • run
  • start-test-app
  • stop-test-app
  • terratest
  • test
  • test-failover
  • test-round-robin
  • uninstall
  • use-first-context
  • use-second-context
  • version
  • vet
  • wait-for-gslb-ready
  • wait-for-nginx-ingress-ready

new

  • clean-test-apps
  • demo-failover
  • demo-roundrobin
  • deploy-full-local-setup
  • destroy-full-local-setup
  • deploy-gslb-operator-14
  • dns-smoke-test
  • dns-tools
  • init-failover
  • init-round-robin
  • lint
  • list (NEW)
  • reset (NEW)
  • start-test-app
  • stop-test-app
  • terratest
  • test-failover
  • test-round-robin
  • version

@ytsarev
Copy link
Member

ytsarev commented Nov 6, 2020

looks like a great reduction of exposed make targets 👍 Looks like test-* targets can be removed as we have demo-* ones with similar functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants