You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to maintain backwards compatibility with existing API, we can add k8gb.io/primary-geotag as alternative and deprecate k8gb.io/primarygeotag later.
I know this is minor issue, and there are no strict conventions on k8s annotations.
But
primary
andgeotag
ink8gb.io/primarygeotag
are two separate words, so it's better to separate them withdash
in order to make annotation more readable, avoid authoring errors, and also align with the style used by existing Ingress Controllers known to community (e.g. https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/, https://doc.traefik.io/traefik/v1.7/configuration/backends/kubernetes/#general-annotations):The text was updated successfully, but these errors were encountered: