Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace k8gb.io/primarygeotag annotation with k8gb.io/primary-geotag #210

Closed
somaritane opened this issue Dec 2, 2020 · 2 comments · Fixed by #212
Closed

Replace k8gb.io/primarygeotag annotation with k8gb.io/primary-geotag #210

somaritane opened this issue Dec 2, 2020 · 2 comments · Fixed by #212
Assignees

Comments

@somaritane
Copy link
Contributor

I know this is minor issue, and there are no strict conventions on k8s annotations.
But primary and geotag in k8gb.io/primarygeotag are two separate words, so it's better to separate them with dash in order to make annotation more readable, avoid authoring errors, and also align with the style used by existing Ingress Controllers known to community (e.g. https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/, https://doc.traefik.io/traefik/v1.7/configuration/backends/kubernetes/#general-annotations):

--- k8gb.io/primarygeotag
+++ k8gb.io/primary-geotag
@somaritane
Copy link
Contributor Author

In order to maintain backwards compatibility with existing API, we can add k8gb.io/primary-geotag as alternative and deprecate k8gb.io/primarygeotag later.

@ytsarev
Copy link
Member

ytsarev commented Dec 2, 2020

No issues with the direct switch imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants