Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseDispatchResultWithPostInfo instead of only DispatchResult, and move out execution logic #21

Open
gdnathan opened this issue Feb 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@gdnathan
Copy link
Collaborator

As out extrinsic weights is very variable "ie: the approve_call might actually execute a whole call, it would be better to compute the weight used in the extrinsic, instead of making the user always pay for the worst case scenario.

We should also move out the actual call execution from the approve_call extrinsic, by, for example, moving approved calls into a different storage, and the on_initialize hook will execute a maximum of available approved calls (we can execute a fixed maximum number, or a fixed maximum weight for example), and pop them out of the storage.

Issue: As the unbounded storage are slowly becoming deprecated by substrate, we cannot just store a vector of "approved calls". We need a better way

@gdnathan gdnathan added the enhancement New feature or request label Feb 13, 2023
@gdnathan gdnathan changed the title UseDispatchResultWithPostInf instead of only DispatchResult, and move out execution logic UseDispatchResultWithPostInfo instead of only DispatchResult, and move out execution logic Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant