Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Add sleep timer notification #380

Open
Hirse opened this issue Dec 20, 2017 · 6 comments
Open

Add sleep timer notification #380

Hirse opened this issue Dec 20, 2017 · 6 comments

Comments

@Hirse
Copy link

Hirse commented Dec 20, 2017

I love the built-in sleep timer functionality and I would like to have a faster way to see how much time is left and potentially the option to extend or remove the sleep timer.

Something like this would be great (taken inspiration and image from Sleep Timer):
sleep-timer-notification

@doompadee
Copy link
Contributor

I like the idea to make the sleep timer more accessible. I think it would be best to extend the playing notification to show the remaining time and include an action to display the sleep timer.

On Nougat or later, notifications already provide a count down chronometer which makes the implementation really simple.

sleeptimer

The sleep timer action only appears when the notification is expanded, but this seems to be the default mode with Phonograph and should therefore suffice to make users be aware of this feature.

What do you think?

@doompadee
Copy link
Contributor

Things are not quite as easy with the legacy notification.

@arkon
What purpose does the "action_quit" ImageButton in the notification_big.xml serve? (It is invisible for me on the Android 4 emulator. I have tintent it yellow for illustration). It takes up precious space...

legacy-notification

@Hirse
Copy link
Author

Hirse commented Jan 10, 2018

@doompadee Thanks for your testing.
I would be fine with a separate notification, too. 😁

@arkon
Copy link
Collaborator

arkon commented Jan 10, 2018

@doompadee Ah, that must have been left over from the older code that had an "x" icon there to close it instead of being able to swipe it away.

@doompadee
Copy link
Contributor

@Hirse
It would be easier to implement, but I find it better to have everything in one place. The timer text takes a bit of space with the legacy notification, but most artist names should still fit fine (will otherwise be cropped a little bit).

@arkon OK, thanks. I will remove it.

@arkon
Copy link
Collaborator

arkon commented May 9, 2018

@AdrienPoupa wrong issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants