Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-08-30 - GitHub で気になるissueをsubscribeした時の通知、「おれもそう思うぜ」みたいなコメントは誰がたしなめようと0にならんのでissueがcloseされた時だけ飛んでほしい #304

Open
kachick opened this issue Aug 29, 2024 · 11 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@kachick
Copy link
Owner

kachick commented Aug 29, 2024

#275
#242

自分で作り込まんでもRSSリーダー的なので案外さくっと実現できたりしそうな気が

@kachick kachick added question Further information is requested blog tips labels Aug 29, 2024
@kachick kachick changed the title 2024-08-30 - GitHub で気になるissueをsubscribeした時の通知、「おれもそう思うぜみたいなコメントは誰がたしなめようと0にならんのでissueがcloseされた時だけ飛んでほしい 2024-08-30 - GitHub で気になるissueをsubscribeした時の通知、「おれもそう思うぜ」みたいなコメントは誰がたしなめようと0にならんのでissueがcloseされた時だけ飛んでほしい Aug 29, 2024
@kachick kachick added help wanted Extra attention is needed and removed blog tips labels Aug 29, 2024
@kachick kachick added this to 🛸 Aug 29, 2024
@github-project-automation github-project-automation bot moved this to 🙋‍♂ in 🛸 Aug 29, 2024
@pankona
Copy link

pankona commented Aug 30, 2024

i agree it

@pankona
Copy link

pankona commented Aug 30, 2024

👍

@kachick
Copy link
Owner Author

kachick commented Aug 30, 2024

く、クソリプ例だ〜!

@kachick
Copy link
Owner Author

kachick commented Aug 30, 2024

https://docs.rsshub.app/routes/programming#issue-pull-request-comments

このツールの https://github.com/DIYgod/RSSHub/blob/f368fa05f0e2e475433732941b9ab0736737fd09/lib/routes/github/comments.ts この辺でコメント投稿からfeed生成出来るようにしてるっぽい。他に issue 全体とかはあるんだけど、issueのステータス変更に対するものはドキュメント上見つかってないのでコメント無しで閉じられたときどうなのかとかは読み解いてみないとなんとも

@kachick
Copy link
Owner Author

kachick commented Aug 30, 2024

@kachick kachick mentioned this issue Aug 30, 2024
11 tasks
@kachick
Copy link
Owner Author

kachick commented Aug 30, 2024

例えばこのスレッド(含むpankona 💩 りぷ) は https://rsshub.app/github/comments/kachick/times_kachick/304 でRSS feedを入手できるようになる

試しにこのコメント付きで閉じて、開けて、無言で閉じて、開けてみる

@kachick kachick closed this as completed Aug 30, 2024
@github-project-automation github-project-automation bot moved this from 🙋‍♂ to 🎉 in 🛸 Aug 30, 2024
@kachick kachick reopened this Aug 30, 2024
@github-project-automation github-project-automation bot moved this from 🎉 to 💪 in 🛸 Aug 30, 2024
@kachick kachick closed this as completed Aug 30, 2024
@github-project-automation github-project-automation bot moved this from 💪 to 🎉 in 🛸 Aug 30, 2024
@kachick kachick reopened this Aug 30, 2024
@github-project-automation github-project-automation bot moved this from 🎉 to 💪 in 🛸 Aug 30, 2024
@pankona
Copy link

pankona commented Aug 30, 2024

💯 I like it!

@kachick
Copy link
Owner Author

kachick commented Aug 30, 2024

<lastBuildDate>Fri, 30 Aug 2024 10:33:53 GMT</lastBuildDate>

ここが1時間超えても更新されない
別に即時更新じゃなくても日次ぐらいなら用は足すんやが、あんま遅いと動作確認的に不便・・・

@kachick
Copy link
Owner Author

kachick commented Aug 30, 2024

webhook を作れるのはあくまで自分が権限持ってるリポジトリだけっぽい

https://github.com/kachick/times_kachick/settings/hooks/new
https://github.com/pankona/install/settings/hooks/new

https://docs.github.com/ja/webhooks/using-webhooks/creating-webhooks

特定のリポジトリで発生したイベントをサブスクライブするWebhook を作成できます。 そのリポジトリに Webhook を作成するには、リポジトリのオーナーであるか、リポジトリの管理者アクセス権が必要です。

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024

https://docs.github.com/ja/rest/issues/issues?apiVersion=2022-11-28#get-an-issue

Get an issue API で state 取れるので、rate limit に引っかかるほどの量じゃなければこれで定期的にポーリングするのが結局簡単そう

@kachick kachick moved this from 🤷‍♂️ to 🙋‍♂ in 🛸 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
Status: 🤷‍♂️
Development

No branches or pull requests

2 participants