Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Quick roll compatability for Ready Set Roll does not appear to work in DnD 3.03 #58

Closed
LeoHuntsman opened this issue Feb 21, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@LeoHuntsman
Copy link

As mentioned in the title. Quick rolls do not appear to apply the relevant advantage or disadvantage. Using Alt to bring up the regular roll menu does appear make it apply as normal.

image

@kaelad02
Copy link
Owner

kaelad02 commented Feb 22, 2024

Guessing the 3.0 changes caused this. What version of Ready Set Roll are you using? I'm sure you updated RSR to 3.0.0 or later, figured I could test against the specific version you have first.

@kaelad02 kaelad02 added the bug Something isn't working label Feb 22, 2024
@kaelad02
Copy link
Owner

I was unable to reproduce the issue. I tested with:

  • dnd5e v3.0.2
  • Advantage Reminder v3.3.0
  • Ready Set Roll v3.0.9

@LeoHuntsman
Copy link
Author

  • dnd5e v3.0.3
  • Advantage Reminder v3.3.0
  • Ready Set Roll v3.0.9

@kaelad02
Copy link
Owner

I was testing attacks, which work fine. I tested skill and ability checks and was able to reproduce it. With the refactoring that RSR did, mainly now using the same hooks that AR uses, the order of the code has swapped. Now AR runs its stuff before RSR. I'll see if it's possible to rearrange that to get AR's hooks to fire after RSR's.

@kaelad02 kaelad02 self-assigned this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants