Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Smart Filters in r/o mode #272

Closed
2 tasks done
vsimeonov-flutter opened this issue Apr 6, 2024 · 2 comments · Fixed by #277
Closed
2 tasks done

Access Smart Filters in r/o mode #272

vsimeonov-flutter opened this issue Apr 6, 2024 · 2 comments · Fixed by #277
Assignees
Labels
good first issue Up for grabs scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working type/regression Something that has been previously fixed but got broken again
Milestone

Comments

@vsimeonov-flutter
Copy link

vsimeonov-flutter commented Apr 6, 2024

Issue submitter TODO list

  • I've searched for an already existing issues here
  • I'm running a supported version of the application which is listed here and the feature is not present there

Is your proposal related to a problem?

When running Kafka UI in Read-Only mode you are not allowed to Add filters.
The error returned is

405 Method Not Allowed
This cluster is in read-only mode.

This issue is cause because filters are now registered in a separate request which is a POST one which is not allowed in r/o mode.

Describe the feature you're interested in

I would like to Add filters in Read-Only mode.

Describe alternatives you've considered

An alternative approach would be to turn off the Read-Only mode which bring security concerns related to the users of the service.
Another alternative is to turn on RBAC and provide proper set of Rules. This approach however is not preferable in during development on local machnine because Authentication method (different than Basic Auth) is required and this brings other issues to it.

Version you're running

2956664 v1.0.0

Additional context

This have been raised as a question in Discord and advised to be raised as issue here.

@vsimeonov-flutter vsimeonov-flutter added status/triage Issues pending maintainers triage type/feature A brand new feature labels Apr 6, 2024
@kapybro kapybro bot added status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 6, 2024
Copy link

github-actions bot commented Apr 6, 2024

Hello there vsimeonov-flutter! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working type/regression Something that has been previously fixed but got broken again and removed type/feature A brand new feature status/triage/manual Manual triage in progress labels Apr 6, 2024
@Haarolean Haarolean added this to the 1.1 milestone Apr 6, 2024
@Haarolean
Copy link
Member

More of a regression as we introduced a separate enpoint for saving filters within #47. I guess saving filters (especially local for every user) is safe enough to bypass by r/o filter. Need to discuss how to approach this in a better way.

@Haarolean Haarolean added the good first issue Up for grabs label Apr 7, 2024
@Haarolean Haarolean moved this to Todo in Up for grabs Apr 7, 2024
@Haarolean Haarolean changed the title FEAT: Allow filter in Read-Only mode Access Smart Filters in r/o mode Apr 10, 2024
@Haarolean Haarolean self-assigned this Apr 10, 2024
@Haarolean Haarolean moved this from Todo to In Development in Up for grabs Apr 10, 2024
@Haarolean Haarolean moved this from Todo to In Development in Release 1.1 Apr 10, 2024
@github-project-automation github-project-automation bot moved this from In Development to Done in Up for grabs Apr 10, 2024
@github-project-automation github-project-automation bot moved this from In Development to Done in Release 1.1 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grabs scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working type/regression Something that has been previously fixed but got broken again
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants