BE: Closes #71 Messages: Show headers duplicates #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi PopClom! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
Haarolean
requested changes
Jan 6, 2025
| return headers; | ||
| } | ||
|
|
||
| private byte[] valueToBytes(Object value) { | ||
| if (value instanceof List<?> || value instanceof Map<?, ?>) { |
There was a problem hiding this comment.
this doesn't look good. I believe in case we have one header value we still have to have a list but of one single element.
There was a problem hiding this comment.
I implemented it this way to ensure headers can still be passed in the same format as before. Otherwise, users would always need to provide a list, which could break compatibility with existing inputs.
There was a problem hiding this comment.
backward compatibility issues are less evil here
Haarolean
added
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Closes #71
Added support for duplicate header keys. If a header holds a single value, it is represented as a string (as it currently works). If it holds multiple values, it's represented as a list of strings. Also added a quick example in the smart filter info modal.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
