Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to store saved filters on the filesystem in detriment of in memory cache #770

Open
2 tasks done
lmirandabrochado opened this issue Jan 13, 2025 · 2 comments
Open
2 tasks done
Labels
status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/feature A brand new feature

Comments

@lmirandabrochado
Copy link

Issue submitter TODO list

  • I've searched for an already existing issues here
  • I'm running a supported version of the application which is listed here and the feature is not present there

Is your proposal related to a problem?

Yes.

I'm constantly using kafbat containers for local testing and, with the most recent upgrades, I noticed that kafbat started storing the saved filters in memory cache, along with the already existing localstorage.

I also noticed that, in addition to the smart filters being stored in memory, there's also the need to post the filterCode value to the /api/clusters/<cluster-name>/topics/<topic-name>/smartfilters endpoint, to have it linked to the browser's local storage.

The flow of operations I need to do on a daily basis to setup filters over and over again increased a lot, and doing simple test cases is getting too cumbersome, as I updated almost all my instances from provectus/kafka-ui to kafbat/kafka-ui, without taking this change to the filters into consideration.

Describe the feature you're interested in

I'm suggesting adding an alternative form of storing this filters.

Describe alternatives you've considered

I've considered adding a filesystem store option (exclusive for containers) so that these filters can alternatively be stored in the filesystem itself instead of in-memory cache.

Version you're running

2956664

Additional context

No response

@lmirandabrochado lmirandabrochado added status/triage Issues pending maintainers triage type/feature A brand new feature labels Jan 13, 2025
@kapybro kapybro bot added status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 13, 2025
Copy link

Hi lmirandabrochado! 👋

Welcome, and thank you for opening your first issue in the repo!

Please wait for triaging by our maintainers.

As development is carried out in our spare time, you can support us by sponsoring our activities or even funding the development of specific issues.
Sponsorship link

If you plan to raise a PR for this issue, please take a look at our contributing guide.

@yeikel
Copy link
Collaborator

yeikel commented Jan 16, 2025

I think that we should consider storing them in Kafka and/or something else. A common use case is cloud deployments where the application state is wiped with every deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/feature A brand new feature
Projects
None yet
Development

No branches or pull requests

2 participants